From dfcfa45be1f6ec9eea27fc770acd68649b3ffa70 Mon Sep 17 00:00:00 2001
From: Michael Nowack <github@minaga-church.de>
Date: Mon, 22 Oct 2018 20:56:50 +0200
Subject: [PATCH] fix(TextTrackSetting): Do not use default button type.
 (#5512)

The default button type is "submit" which triggers a form submit. Thus
if videojs is embedded in a form element the button triggers a form
submit.

This is the same problem with same solution as discussed in https://github.com/videojs/video.js/issues/2470
---
 src/js/tracks/text-track-settings.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/js/tracks/text-track-settings.js b/src/js/tracks/text-track-settings.js
index 7530883fb4..9f67954845 100644
--- a/src/js/tracks/text-track-settings.js
+++ b/src/js/tracks/text-track-settings.js
@@ -464,11 +464,11 @@ class TextTrackSettings extends ModalDialog {
     return createEl('div', {
       className: 'vjs-track-settings-controls',
       innerHTML: [
-        `<button class="vjs-default-button" title="${defaultsDescription}">`,
+        `<button type="button" class="vjs-default-button" title="${defaultsDescription}">`,
         this.localize('Reset'),
         `<span class="vjs-control-text"> ${defaultsDescription}</span>`,
         '</button>',
-        `<button class="vjs-done-button">${this.localize('Done')}</button>`
+        `<button type="button" class="vjs-done-button">${this.localize('Done')}</button>`
       ].join('')
     });
   }