fix: remove title attribute on menu items, fixes #3699 (#4009)

videojs · Feb 7, 2017 · 91874a3 · 91874a3
1 parent daad492
commit 91874a3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/src/css/video-js.scss b/src/css/video-js.scss
@@ -2,7 +2,7 @@
 @import "private-variables";
 @import "utilities";
 
-@import "node_modules/videojs-font/scss/icons";
+@import "../../node_modules/videojs-font/scss/icons";
 
 @import "components/layout";
 @import "components/big-play";

diff --git a/src/js/clickable-component.js b/src/js/clickable-component.js
@@ -121,7 +121,11 @@ class ClickableComponent extends Component {
 
     this.controlText_ = text;
     this.controlTextEl_.innerHTML = localizedText;
-    el.setAttribute('title', localizedText);
+
+    if (!this.nonIconControl) {
+      // Set title attribute if only an icon is shown
+      el.setAttribute('title', localizedText);
+    }
 
     return this;
   }

diff --git a/src/js/menu/menu-item.js b/src/js/menu/menu-item.js
@@ -54,6 +54,9 @@ class MenuItem extends ClickableComponent {
    *         The element that gets created.
    */
   createEl(type, props, attrs) {
+    // The control is textual, not just an icon
+    this.nonIconControl = true;
+
     return super.createEl('li', assign({
       className: 'vjs-menu-item',
       innerHTML: this.localize(this.options_.label),