From 61d427c7eefe23bc3c7d43c061fe44f1e85e5f29 Mon Sep 17 00:00:00 2001 From: Gary Katsevman Date: Thu, 2 Mar 2017 15:04:35 -0500 Subject: [PATCH] fix: add buildWrapperCSSClass methods to all menu buttons (#4147) In #4034, we changed the way that menu buttons work slightly by introduction a wrapper element with a separate wrapper css builder. However, this broke, at least the playback-rate menu. This PR adds a buildWrapperCSSClass to each of our menu buttons. --- .../playback-rate-menu/playback-rate-menu-button.js | 4 ++++ src/js/control-bar/text-track-controls/captions-button.js | 4 ++++ src/js/control-bar/text-track-controls/chapters-button.js | 4 ++++ src/js/control-bar/text-track-controls/descriptions-button.js | 3 +++ src/js/control-bar/text-track-controls/subtitles-button.js | 3 +++ 5 files changed, 18 insertions(+) diff --git a/src/js/control-bar/playback-rate-menu/playback-rate-menu-button.js b/src/js/control-bar/playback-rate-menu/playback-rate-menu-button.js index a446208b08..98d3404572 100644 --- a/src/js/control-bar/playback-rate-menu/playback-rate-menu-button.js +++ b/src/js/control-bar/playback-rate-menu/playback-rate-menu-button.js @@ -62,6 +62,10 @@ class PlaybackRateMenuButton extends MenuButton { return `vjs-playback-rate ${super.buildCSSClass()}`; } + buildWrapperCSSClass() { + return `vjs-playback-rate ${super.buildWrapperCSSClass()}`; + } + /** * Create the playback rate menu * diff --git a/src/js/control-bar/text-track-controls/captions-button.js b/src/js/control-bar/text-track-controls/captions-button.js index 9eef8ec1d4..6c77c23bd2 100644 --- a/src/js/control-bar/text-track-controls/captions-button.js +++ b/src/js/control-bar/text-track-controls/captions-button.js @@ -38,6 +38,10 @@ class CaptionsButton extends TextTrackButton { return `vjs-captions-button ${super.buildCSSClass()}`; } + buildWrapperCSSClass() { + return `vjs-captions-button ${super.buildWrapperCSSClass()}`; + } + /** * Update caption menu items * diff --git a/src/js/control-bar/text-track-controls/chapters-button.js b/src/js/control-bar/text-track-controls/chapters-button.js index 89afe232bd..977dfeb075 100644 --- a/src/js/control-bar/text-track-controls/chapters-button.js +++ b/src/js/control-bar/text-track-controls/chapters-button.js @@ -41,6 +41,10 @@ class ChaptersButton extends TextTrackButton { return `vjs-chapters-button ${super.buildCSSClass()}`; } + buildWrapperCSSClass() { + return `vjs-chapters-button ${super.buildWrapperCSSClass()}`; + } + /** * Update the menu based on the current state of its items. * diff --git a/src/js/control-bar/text-track-controls/descriptions-button.js b/src/js/control-bar/text-track-controls/descriptions-button.js index 4eeffa3d8c..f98f70955c 100644 --- a/src/js/control-bar/text-track-controls/descriptions-button.js +++ b/src/js/control-bar/text-track-controls/descriptions-button.js @@ -76,6 +76,9 @@ class DescriptionsButton extends TextTrackButton { return `vjs-descriptions-button ${super.buildCSSClass()}`; } + buildWrapperCSSClass() { + return `vjs-descriptions-button ${super.buildWrapperCSSClass()}`; + } } /** diff --git a/src/js/control-bar/text-track-controls/subtitles-button.js b/src/js/control-bar/text-track-controls/subtitles-button.js index 33eb57642a..0ded7e8231 100644 --- a/src/js/control-bar/text-track-controls/subtitles-button.js +++ b/src/js/control-bar/text-track-controls/subtitles-button.js @@ -37,6 +37,9 @@ class SubtitlesButton extends TextTrackButton { return `vjs-subtitles-button ${super.buildCSSClass()}`; } + buildWrapperCSSClass() { + return `vjs-subtitles-button ${super.buildWrapperCSSClass()}`; + } } /**