Skip to content

Commit

Permalink
fix: add buildWrapperCSSClass methods to all menu buttons (#4147)
Browse files Browse the repository at this point in the history
In #4034, we changed the way that menu buttons work slightly by introduction a wrapper element with a separate wrapper css builder. However, this broke, at least the playback-rate menu.
This PR adds a buildWrapperCSSClass to each of our menu buttons.
  • Loading branch information
gkatsev committed Mar 2, 2017
1 parent a9f8fcb commit 61d427c
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@ class PlaybackRateMenuButton extends MenuButton {
return `vjs-playback-rate ${super.buildCSSClass()}`;
}

buildWrapperCSSClass() {
return `vjs-playback-rate ${super.buildWrapperCSSClass()}`;
}

/**
* Create the playback rate menu
*
Expand Down
4 changes: 4 additions & 0 deletions src/js/control-bar/text-track-controls/captions-button.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ class CaptionsButton extends TextTrackButton {
return `vjs-captions-button ${super.buildCSSClass()}`;
}

buildWrapperCSSClass() {
return `vjs-captions-button ${super.buildWrapperCSSClass()}`;
}

/**
* Update caption menu items
*
Expand Down
4 changes: 4 additions & 0 deletions src/js/control-bar/text-track-controls/chapters-button.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,10 @@ class ChaptersButton extends TextTrackButton {
return `vjs-chapters-button ${super.buildCSSClass()}`;
}

buildWrapperCSSClass() {
return `vjs-chapters-button ${super.buildWrapperCSSClass()}`;
}

/**
* Update the menu based on the current state of its items.
*
Expand Down
3 changes: 3 additions & 0 deletions src/js/control-bar/text-track-controls/descriptions-button.js
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,9 @@ class DescriptionsButton extends TextTrackButton {
return `vjs-descriptions-button ${super.buildCSSClass()}`;
}

buildWrapperCSSClass() {
return `vjs-descriptions-button ${super.buildWrapperCSSClass()}`;
}
}

/**
Expand Down
3 changes: 3 additions & 0 deletions src/js/control-bar/text-track-controls/subtitles-button.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ class SubtitlesButton extends TextTrackButton {
return `vjs-subtitles-button ${super.buildCSSClass()}`;
}

buildWrapperCSSClass() {
return `vjs-subtitles-button ${super.buildWrapperCSSClass()}`;
}
}

/**
Expand Down

0 comments on commit 61d427c

Please sign in to comment.