Support 4k content on bowsers with limited MSE buffer

[gesinger]

Tracking PRs (which should eventually get merged into http-streaming):
"handle dynamic buffer sizes (4k support)"
videojs/videojs-contrib-hls#1416
"Graceful handling of QuotaExceededError"
videojs/videojs-contrib-media-sources#178

Related:
https://github.com/videojs/videojs-contrib-hls/issues/1435

[welcome]

👋 Thanks for opening your first issue here! 👋

If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.
To help make it easier for us to investigate your issue, please follow the contributing guidelines.

[leonhandreke]

For anybody facing the Failed to execute 'appendBuffer' on 'SourceBuffer': The SourceBuffer is full error with high-bitrate videos: I cranked down videojs.Hls.MAX_GOAL_BUFFER_LENGTH and videojs.Hls.GOAL_BUFFER_LENGTH to 30. I couldn't really make sense of the code in

http-streaming/src/master-playlist-controller.js

Lines 1191 to 1198 in b820f24

	goalBufferLength() {
	const currentTime = this.tech_.currentTime();
	const initial = Config.GOAL_BUFFER_LENGTH;
	const rate = Config.GOAL_BUFFER_LENGTH_RATE;
	const max = Math.max(initial, Config.MAX_GOAL_BUFFER_LENGTH);
	return Math.min(initial + currentTime * rate, max);
	}

but that fixed it, now the buffer is shorter.

It's an ugly hack but it works ¯_(ツ)_/¯

[asadmalik3]

@leonhandreke is there a neat way to change value of MAX_GOAL_BUFFER_LENGTH from video js?

[leonhandreke]

@asadmalik3 yes, you can just set videojs.Hls.MAX_GOAL_BUFFER_LENGTH = 30; in your code before initializing your player. Hope that helps!

[johneisenheim]

Hello! Thanks for this fixes...Is there any way to apply the fixes above on MPEG-Dash? On older browser (like Chrome 55) the error is still reproduced with mpd files. Thank you again!

[jeopard]

Hey! Thank you for all the great work! I just wanted to let you know that the videojs.Hls.MAX_GOAL_BUFFER_LENGTH = 30; doesn't work for Firefox, as I still get the append buffer error. I'm using video.js 7.8.4 with http-streaming 1.13.2.

I'm guessing this issue is a duplicate of #344 ?

[gkatsev]

Yup, they're very likely the same issue.

[gkatsev]

Closing in favor #344.