feat(influxdb): add path and protocol to config input #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haas-ac
force-pushed
the
add_influxdb_config_params
branch
from
89e6af6 to
e1e94dc
Compare
|
tested and works well :) |
|
This looks pretty clean and nice @maurerle, let me please just re-test it in my environments and I think it will be ready to merge... |
|
@maurerle I have (with your kind permission) adjusted couple things to make it better fit the rest of the code. The InfluxDB settings layout is now responsive single line to consume less space. The Could you please test whether it works as expected before we merge it? |
|
works well, LGTM :) |
mman
pushed a commit
that referenced
this pull request
Dec 16, 2024
# [1.4.0](1.3.1...1.4.0) (2024-12-16) ### Bug Fixes * Add Filter/Close button to device pills ([ed4812b](ed4812b)) * Clarify measurements/sec on Dashboard ([70962e6](70962e6)) * Display VRM token name/id in UI ([8b60d91](8b60d91)) * Implement basic log filtering ([e0bff62](e0bff62)) * Implement correct log filtering for VRM devices ([cbf044b](cbf044b)) * Improve Troubleshooting page experience ([0de2907](0de2907)) * Show badge close button to indicate filter is active ([3298db5](3298db5)) * Turn AppContent into flex container ([4d98480](4d98480)) * Use `idAccessToken` returned via `/me` endpoint to derive VRM token name ([80c6b57](80c6b57)) * Use `My Installations`, and `Other` in VRM settings ([66e65fa](66e65fa)) * Validate VRM token on refresh, determine token name ([5b04cba](5b04cba)) ### Features * Allow custom per device MQTT subscription ([1b06965](1b06965)) * **influxdb:** add path and protocol to config input ([#206](#206)) ([5508a88](5508a88))
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR to add protocol and path to influxdb client
closes #205