Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--extpass return code is not checked #676

Open
mserdarsanli opened this issue Mar 15, 2025 · 0 comments
Open

--extpass return code is not checked #676

mserdarsanli opened this issue Mar 15, 2025 · 0 comments

Comments

@mserdarsanli
Copy link

mserdarsanli commented Mar 15, 2025

For getting the user password EncFSConfig::getUserKey does not seem to check exit status of the external command and use its stdout regardless.

If --extpass is used while creating a new filesystem and the external program fails with some output on its stdout (otherwise you get fatal: zero-length passwords are not allowed ), then user would be creating a filesystem with potentially no way to recover files. I noticed this by passing wrong flags to external process that caused it to print usage text and fail, while filesystem creation succeeded. encfs command should instead check exit status of subprocess after the waitpid call and fail if it is not 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant