Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom data integrations now require callerIsSyncAdapter: Boolean parameter #313

Closed
2 tasks done
vestrel00 opened this issue Sep 5, 2023 · 2 comments
Closed
2 tasks done

Custom data integrations now require callerIsSyncAdapter: Boolean parameter #313

vestrel00 opened this issue Sep 5, 2023 · 2 comments
Assignees
@vestrel00
Labels
breaking change This may break integration of the library for some consumers

Comments

@vestrel00
Copy link
Owner

vestrel00 commented Sep 5, 2023 •
edited
Loading

Problem

Due to #308, custom data integrations will cause compilation errors.

Solution

Add callerIsSyncAdapter: Boolean in all required places.
@vestrel00 vestrel00 added the breaking change This may break integration of the library for some consumers label Sep 5, 2023
@vestrel00 vestrel00 self-assigned this Sep 5, 2023
@vestrel00 vestrel00 mentioned this issue Sep 1, 2023
Closed
6 tasks
@vestrel00 vestrel00 changed the title Custom data integrations new require callerIsSyncAdapter: Boolean Custom data integrations now require callerIsSyncAdapter: Boolean Sep 6, 2023
@vestrel00
Copy link
Owner Author

Migration guide (to be included in release notes)

Add callerIsSyncAdapter: Boolean as the first parameter to your AbstractCustomDataOperation.Factory.create functions and AbstractCustomDataOperation constructors.

@vestrel00 vestrel00 changed the title Custom data integrations now require callerIsSyncAdapter: Boolean Custom data integrations now require callerIsSyncAdapter: Boolean parameter Sep 8, 2023
@vestrel00
Copy link
Owner Author

🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥
This is now release in 0.3.1!
🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vestrel00 vestrel00

Labels
breaking change This may break integration of the library for some consumers
Projects
General maintenance
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vestrel00