Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BlankRawContact entity #269

Closed
7 tasks done
vestrel00 opened this issue Oct 24, 2022 · 2 comments
Closed
7 tasks done

Remove BlankRawContact entity #269

vestrel00 opened this issue Oct 24, 2022 · 2 comments
Assignees
Labels
breaking change This may break integration of the library for some consumers

Comments

@vestrel00
Copy link
Owner

vestrel00 commented Oct 24, 2022

Problem

Due to the changes in #268, it no longer makes sense to keep the BlankRawContact entity. The main purpose of the BlankRawContact in conjunction with the AccountsRawContactsQuery was to provide users a way to get a list of RawContacts and their display name and account, all of which are now a part of the regular RawContact entity.

Solution

  • Delete BlankRawContact and replace references with RawContact
  • Delete ExistingRawContactEntityWithContactId and replace references with ExistingRawContactEntity

Additionally;

  • Update sample app
  • Update cheatsheet (also move to basics section)
  • Update relevant documentation in code
  • Verify that there are no regressions for related API functions
  • Provide a migration guide as a comment in this issue so that it can be copy-pasted into the release notes
@vestrel00 vestrel00 added enhancement New feature or request breaking change This may break integration of the library for some consumers labels Oct 24, 2022
@vestrel00 vestrel00 self-assigned this Oct 24, 2022
@vestrel00 vestrel00 pinned this issue Oct 24, 2022
@vestrel00 vestrel00 changed the title Generalize/expand AccountsRawContactsQuery to RawContactsQuery Remove BlankRawContact entity and generalize AccountsRawContactsQuery to RawContactsQuery Oct 24, 2022
@vestrel00 vestrel00 changed the title Remove BlankRawContact entity and generalize AccountsRawContactsQuery to RawContactsQuery Remove BlankRawContact entity Oct 25, 2022
@vestrel00 vestrel00 removed the enhancement New feature or request label Oct 25, 2022
@vestrel00 vestrel00 changed the title Remove BlankRawContact entity Remove BlankRawContact entity and generalize AccountsRawContactsQuery to RawContactsQuery Oct 25, 2022
@vestrel00 vestrel00 added the enhancement New feature or request label Oct 25, 2022
@vestrel00 vestrel00 changed the title Remove BlankRawContact entity and generalize AccountsRawContactsQuery to RawContactsQuery Remove BlankRawContact entity Oct 31, 2022
@vestrel00 vestrel00 removed the enhancement New feature or request label Oct 31, 2022
@vestrel00 vestrel00 changed the title Remove BlankRawContact entity Remove BlankRawContact entity Oct 31, 2022
@vestrel00 vestrel00 changed the title Remove BlankRawContact entity Remove BlankRawContact entity Oct 31, 2022
@vestrel00 vestrel00 unpinned this issue Oct 31, 2022
@vestrel00
Copy link
Owner Author

Migration guide (to be included in release notes)

Now that BlankRawContact no longer exists, all you have to do is replace any references you may have to it with references to RawContact.

@vestrel00
Copy link
Owner Author

This is included in 0.3.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This may break integration of the library for some consumers
Projects
None yet
Development

No branches or pull requests

1 participant