Delete, ProfileDelete, and DataDelete API results isSuccessful is true even though delete failed

[vestrel00]

Problem

As discovered in #224, Delete, ProfileDelete, and DataDelete API results isSuccessful is true even though delete failed.

Evaluation of delete success is currently,

applyBatch(deleteOperation) != null

This works just fine for update operations where the result is always ContentProviderResult(count=0) even if the update operation succeeded on one or more entities. However, for successful delete operations, the output is ContentProviderResult(count=1). If the entity being deleted is not found or delete failed, then count=0.

Solution

Change evaluation of delete success to,

applyBatch(deleteOperation)?.firstOrNull()?.count?.let { it > 0 } == true

This has the following side effect;

• Previously, deleting already deleted entities will result in success=true
• After this issue is fixed, deleting already deleted entities will result in success=false

[vestrel00]

This is included in release 0.2.2 🥳