Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The GroupsUpdate API allows for duplicate titles when it should not #108

Closed
vestrel00 opened this issue Nov 26, 2021 · 0 comments
Closed
Assignees
Labels
bug Something isn't working

Comments

@vestrel00
Copy link
Owner

The Contacts Provider allows multiple groups with the same title (case-sensitive comparison) belonging to the same account to exist. In older versions of Android, the native Contacts app allows the creation of new groups with existing titles. In newer versions, duplicate titles are not allowed. Therefore, this library does not allow for duplicate titles.

Currently, the library's GroupsInsert API follows the behavior of newer versions of Android. Inserting a group with a title that already exists in the same Account will fail. However, using the GroupsUpdate API allows consumers to update the title to an existing title, thereby creating a duplicate.

Later on, the group with the duplicate title gets deleted either automatically by the Contacts Provider or when viewing groups in the native Contacts app. It's not an immediate failure on insert or update. This could lead to bugs!

@vestrel00 vestrel00 added the bug Something isn't working label Nov 26, 2021
@vestrel00 vestrel00 self-assigned this Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant