Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the client_white_list info from the error message when client is not compatible with server #5788

Closed
Nicole00 opened this issue Dec 22, 2023 · 0 comments · Fixed by #5797
Closed

remove the client_white_list info from the error message when client is not compatible with server #5788

Nicole00 opened this issue Dec 22, 2023 · 0 comments · Fixed by #5797
Assignees
@dutor
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@Nicole00
Copy link
Contributor

Nicole00 commented Dec 22, 2023 •
edited
Loading

When the client sets a version that does not match the server's client_white_list, the error message should not print out the version information available on the server. Because now the client_white_list acts as KEY for server and client.

related requirement: https://github.com/vesoft-inc/requirement-holder/issues/762

Current client is not compatible with the remote server, please check the version: Graph client version(INVALID_VERSION) is not accepted, current graph client white list: test3.0.0.

@MuYiYong determines the name(name for verifyVersion value) to users for SDK is handshakeKey
@Nicole00 Nicole00 added the type/enhancement Type: make the code neat or more efficient label Dec 22, 2023
@wey-gu wey-gu mentioned this issue Dec 23, 2023
Closed
@Nicole00 Nicole00 changed the title the client version white list info lacks of delimiter remove the client_white_list info from the error message when client is not compatible with server Jan 5, 2024
@Nicole00 Nicole00 mentioned this issue Jan 5, 2024
Merged
@wey-gu wey-gu mentioned this issue Jan 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dutor dutor

Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix the error message for verifyVersion vesoft-inc/nebula
2 participants
@dutor @Nicole00