Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the name of option disable_page_cache #5311

Open
Qiaolin-Yu opened this issue Feb 5, 2023 · 0 comments
Open

Change the name of option disable_page_cache #5311

Qiaolin-Yu opened this issue Feb 5, 2023 · 0 comments
Labels
type/enhancement Type: make the code neat or more efficient

Comments

@Qiaolin-Yu
Copy link
Contributor

Introduction

Due to the RocksDB Wiki, options related to direct io include use_direct_reads and use_direct_io_for_flush_and_compaction. However, according to the code, the option disable_page_cache of Nebula only changes use_direct_reads. Furthermore, direct I/O for WAL and Manifest files is not supported yet. Therefore, this does not mean that page cache is disabled, and I think this name (disable_page_cache) is a little confusing.

Contents

Related work
@Qiaolin-Yu Qiaolin-Yu added the type/enhancement Type: make the code neat or more efficient label Feb 5, 2023
@wey-gu wey-gu mentioned this issue Feb 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Type: make the code neat or more efficient
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Qiaolin-Yu