-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support to set headers for http2 #548
Conversation
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #548 +/- ##
============================================
- Coverage 62.98% 62.92% -0.06%
- Complexity 801 802 +1
============================================
Files 72 72
Lines 3942 3960 +18
Branches 539 539
============================================
+ Hits 2483 2492 +9
- Misses 1089 1097 +8
- Partials 370 371 +1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's amazing to find that you've created the setCustomHeaders
interface in advance. Well done. Let's wait for other Java folks to review the PR.
if (isUseHttp2) { | ||
this.useHttp2 = isUseHttp2; | ||
this.headers = headers; | ||
if (useHttp2) { | ||
getProtocolForHttp2(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
headers are only for useHttp2=true
, only used for HTTPClient
prefer getProtocolForHttp2(headers);
and do not use this.headers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reopen will use headers when useHttp2 is true, need a global var to save the info.
close #547