New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to setHeader when using HTTP/2 #547

Closed

Nicole00 opened this issue Sep 14, 2023 · 0 comments · Fixed by #548

Labels

type/feature req

Contributor

Nicole00 commented Sep 14, 2023

Need capability to add route tags (basically http headers) in nebula client.

Considering adding a field about the TAG in the session pool config. Then when initializing connection, call transport.SetHeader(key string, value string). https://github.com/vesoft-inc/fbthrift/blob/main/thrift/lib/go/thrift/http_client.go#L133

Note here the SetHeader use http.header.Add method, which may cause a bug similar to here: https://github.com/vesoft-inc/nebula-ent/issues/2266#issuecomment-1414517627
Please verify and update thrift if necessary.

Nicole00 added the type/feature req label

Nicole00 mentioned this issue

support to set headers for http2 #548

Merged

Nicole00 closed this as completed in #548

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment