fix(title): fix copying on WSL 2 by bumping clipboardy version #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In [this PR](sindresorhus/clipboardy#59), support for WSL was added in `clipboardy` v2.3.0. Since WSL support for `title` would be nice, `clipboardy`'s version was increased from 1.2.2 to 3.0.0. Because `clipboardy` is now an ES module, the method of importing it had to change to use the `import` function rather than `require`.
|
Are you interested in tackling #69? |
After reading through the ticket and the linked gist, I would say I'm interested in trying to address it! |
|
Awesome, yeah I figured I'd mention that since it's related to this PR. |
vaudy
approved these changes
Feb 7, 2023
|
it would be nice to have this fix since it also fix vulnerabilities issue for using exec 0.8.0 |
|
#83 includes updating |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit message
In this PR, support for WSL was added in
clipboardyv2.3.0. Since WSLsupport for
titlewould be nice,clipboardy's version was increasedfrom 1.2.2 to 3.0.0.
Because
clipboardyis now an ES module, the method of importing it hadto change to use the
importfunction rather thanrequire.Additional information
After testing locally in WSl 2, I've confirmed that the changes does enable auto-copying on WSL to function as described. When I ran the tests, they all passed. Albeit, it was on Node
v17.0.1.There is no
enginesfield in thepackage.jsonfile specifying the node version, so I'm unsure if this PR would count as a breaking change to usingimport.Please let me know of any changes I should make!