-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecated subdependencies found in @mapbox/node-pre-gyp #421
Comments
There is some related discussion here: #407 (comment) Would you like to submit a PR to fix it? |
Compare https://npmgraph.js.org/?q=argon2 vs https://npmgraph.js.org/?q=argon2@0.31.1. The new version drops 55 dependencies including |
I sent #431 to upgrade |
Its not related to I looked at how consumers are using it (for example, argon2) and its just a single function export: const binary = require("@mapbox/node-pre-gyp");
const bindingPath = binary.find(path.resolve(__dirname, "./package.json")); So perhaps we could implement this Do you want to submit a PR to implement this? |
I see. That makes much more sense to me. Thanks! It's not exactly clear to me that
|
The latter library is dramatically lighter. I wonder if we could make the same switch here |
@styfle based on the link from my past comment, do you think something like this might work? It looks like |
nft supports both |
@styfle @benmccann Hey guys, sorry for pinging u but any updates on this one? |
I don't understand the changes that would need to be made here to remove the use of |
Description
When installing dependencies for our project that uses
@vercel/nft
, we encountered warnings about deprecated subdependencies. These warnings are caused by the@mapbox/node-pre-gyp
package, which is a dependency of@vercel/nft
.Details
The following deprecated subdependencies are reported during
pnpm install
:are-we-there-yet@2.0.0
gauge@3.0.2
inflight@1.0.6
npmlog@5.0.1
Expected Behavior
Dependencies within
@vercel/nft
should not rely on deprecated packages to ensure better security and compatibility with modern development environments.Additional Information
The text was updated successfully, but these errors were encountered: