Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use case-sensitive-paths-webpack-plugin #696

Closed
arunoda opened this issue Jan 8, 2017 · 4 comments · May be fixed by gsoc2/next.js#4
Closed

Use case-sensitive-paths-webpack-plugin #696

arunoda opened this issue Jan 8, 2017 · 4 comments · May be fixed by gsoc2/next.js#4

Comments

@arunoda
Copy link
Contributor

arunoda commented Jan 8, 2017

Mostly in macOs it resolves files without case-insensitively. This will cause errors in production.

Discussion on slack: https://zeit-community.slack.com/archives/next/p1483839382004382

@rauchg
Copy link
Member

rauchg commented Jan 8, 2017

By the way, I haven't looked at the precise implementation details, but I'd like to make sure we handle this case:

  • ./pages/index.js
  • ./pages/About.js

Inside ./pages/index:

import Link from 'next/prefetch'
export default () => (
  <Link href="/about"><a>Hi</a></Link>
)

This will work on the mac but not Linux. We might want to add a check at the /_next routes handler for that case. Actually, it might be the only place where it's needed?

@arunoda
Copy link
Contributor Author

arunoda commented Jan 8, 2017

@rauchg good point.

@arunoda
Copy link
Contributor Author

arunoda commented Jan 8, 2017

But we still need to add this webpack plugin because it's related to imports.
We need to handle this with about page resolver too.

@rauchg
Copy link
Member

rauchg commented Jan 8, 2017

Yeah good point

@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants