Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HMR ReferenceError and related errors should render as a red error on the screen #648

Closed
rauchg opened this issue Jan 3, 2017 · 1 comment
Assignees

Comments

@rauchg
Copy link
Member

rauchg commented Jan 3, 2017

Referencing a component that hasn't been imported for example is yielding only an error in the web console, which makes things tedious to debug.

@nkzawa
Copy link
Contributor

nkzawa commented Jan 4, 2017

We do support rendering runtime errors as a red error on the screen, but it's only when it occurred on module loading.

I wonder exactly when we should do this:

  • errors on lifecycle methods of React.
  • any runtime errors (maybe caches them using window.onerror)

I guess you meant about lifecycle methods ?

btw usually, we can't handle errors occurred on render of React (facebook/react#2461). We'd have to monkeypatch React.

@lock lock bot locked as resolved and limited conversation to collaborators May 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants