Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive in circular structure detection #16393

Closed
m-lautenbach opened this issue Aug 20, 2020 · 3 comments
Closed

False positive in circular structure detection #16393

m-lautenbach opened this issue Aug 20, 2020 · 3 comments

Comments

@m-lautenbach
Copy link
Contributor

Bug report

Describe the bug

Dev server interprets arrays containing the same object multiple times as circular structure.

To Reproduce

Steps to reproduce the behavior, please provide code snippets or a repository:

  1. call isSerializableProps on an object containing an array which contains the same object twice
  2. this happened to us during development (presumably because ApolloJS in-memory cache)

Expected behavior

An array which contains the same object twice should not be rejected a cyclical.

Screenshots

Screenshot 2020-08-20 at 14 25 21

System information

should be system independent, but happy to provide if it can't be reproduced.

Additional context

I opened a pull request with a fix and a test case to cover it: #16380

@jamesmosier
Copy link
Contributor

Closing as #16380 was merged.

@m-lautenbach
Copy link
Contributor Author

thanks 👍

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants