Private class fields break build

[dominiklessel]

I have a project, which uses hapi. With their latest 19.x release they dropped support for node 10 and make use of for example private class fields, which now breaks my ncc build :

> ncc build

ncc: Version 0.20.5
ncc: Compiling file index.js
Error: Module parse failed: Unexpected character '#' (17:4)
File was processed with these loaders:
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/empty-loader.js
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/relocate-loader.js
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/shebang-loader.js
You may need an additional loader to handle the result of these loaders.
| exports = module.exports = internals.Auth = class {
| 
>     #core = null;
|     #schemes = {};
|     #strategies = {};
Module parse failed: Unexpected token (51:12)
File was processed with these loaders:
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/empty-loader.js
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/relocate-loader.js
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/shebang-loader.js
You may need an additional loader to handle the result of these loaders.
| exports = module.exports = internals.Core = class {
| 
>     actives = new WeakMap();                                                   // Active requests being processed
|     app = {};
|     auth = new Auth(this);
Module parse failed: Unexpected token (12:9)
File was processed with these loaders:
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/empty-loader.js
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/relocate-loader.js
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/shebang-loader.js
You may need an additional loader to handle the result of these loaders.
| exports = module.exports = internals.Ext = class {
| 
>     type = null;
|     nodes = null;
| 
Module parse failed: Unexpected token (246:10)
File was processed with these loaders:
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/empty-loader.js
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/relocate-loader.js
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/shebang-loader.js
You may need an additional loader to handle the result of these loaders.
| exports.ValidationError = class extends Error {
| 
>     isJoi = true;
|     name = 'ValidationError';
| 
Module parse failed: Unexpected character '#' (8:4)
File was processed with these loaders:
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/empty-loader.js
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/relocate-loader.js
 * ./node_modules/@zeit/ncc/dist/ncc/loaders/shebang-loader.js
You may need an additional loader to handle the result of these loaders.
| exports.Team = internals.Team = class {
| 
>     #meetings = null;
|     #count = null;
|     #notes = null;
    at evalmachine.<anonymous>:1:1501918
    at eval (eval at create (evalmachine.<anonymous>:1:273391), <anonymous>:13:1)
    at processTicksAndRejections (internal/process/task_queues.js:94:5)

Please see their changelogs:

• https://hapi.dev/resources/changelog/
• Use private class fields hapijs/hapi#4013

Is there any way around it?

[ngduc]

I'm also getting this issue today. Thanks.

[hatemjaber]

What does You may need an additional loader to handle the result of these loaders mean? How do you add additional loaders so that when you run ncc build... it knows to use them? I've been searching trying to find an answer and can't seem to find one.

[itsdarrylnorris]

@dominiklessel Are you aware of a workaround?

[dominiklessel]

@itsdarrylnorris No, unfortunately not – I've stopped using ncc because of this … I know that this is not a feasible solution for everyone, but in my case it was (and I was too lazy to figure out a proper fix 😬)

Have a look at https://github.com/OnurGvnc/acorn-with-stage3 this looks like a possible workaround 👍

[Dunky13]

Facing this problem too, but the acorn suggestion doesn't work for me.

[guybedford]

@Dunky13 I just tested this and private fields definitely seem to be supported. Are you sure you're using the latest version?