Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MJML dependency breaks the build process #276

Closed
bfulop opened this issue Feb 11, 2019 · 1 comment
Closed

MJML dependency breaks the build process #276

bfulop opened this issue Feb 11, 2019 · 1 comment

Comments

@bfulop
Copy link

bfulop commented Feb 11, 2019

I'm trying to get a very simple repo working, with only one dependency: https://www.npmjs.com/package/mjml

As soon as I include import mjml2html from 'mjml' in my date.js file, ncc run date.js will fail:

  52kB  mime.types
 121kB  sourcemap-register.js
4272kB  index.js
4744kB  index.js.map
4445kB  [8914ms]

/private/var/folders/r2/br0p741168qg5n2h65fzsdz40000gn/T/d41d8cd98f00b204e9800998ecf8427e/index.js:66898
	var e = new Error("Cannot find module '" + req + "'");
         ^
Error: Cannot find module '../lib/utils.js'
    at Function.webpackEmptyContext [as resolve] (/private/var/folders/r2/br0p741168qg5n2h65fzsdz40000gn/T/d41d8cd98f00b204e9800998ecf8427e/index.js:66898:10)
    at /node_modules/uglify-js/tools/node.js:17:1
    at Array.map (<anonymous>)
    at Object.3210 (/node_modules/uglify-js/tools/node.js:16:1)
    at __webpack_require__ (/webpack:bootstrap:19:1)
    at Object.959 (/node_modules/html-minifier/src/htmlminifier.js:8:1)
    at __webpack_require__ (/webpack:bootstrap:19:1)
    at Object.7097 (/node_modules/mjml-core/lib/index.js:61:1)
    at __webpack_require__ (/webpack:bootstrap:19:1)
    at Object.9746 (/node_modules/mjml/lib/index.js:7:1)

Here's a minimal repo to reproduce the issue : https://github.com/bfulop/zeitwithyarn

@bfulop
Copy link
Author

bfulop commented Feb 12, 2019

Closing this in favour of #277, it's more focused on the root of the problem...

@bfulop bfulop closed this as completed Feb 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant