Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

256 terminal color support #364

Closed
codedmart opened this issue Jul 22, 2016 · 16 comments
Closed

256 terminal color support #364

codedmart opened this issue Jul 22, 2016 · 16 comments
Labels
🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper

Comments

@codedmart
Copy link

Does hyperterm support 256 colors? I am using hyperterm-tomorrow-night, base16-tomorrow-night.vim, and base16-tomorrow-night shell themes but unless I have something configured wrong 256 colors are not working. I have tried other themes as well.

screen shot 2016-07-22 at 6 34 11 am

@codedmart codedmart changed the title Base16 256 color support 256 terminal color support Jul 22, 2016
@codedmart
Copy link
Author

I was running the script wrong. It seems to be working ok in hyperterm itself, but vim colors are still not correct. Still investigating.

@codedmart
Copy link
Author

Also to note that vim looks fine and correct in iTerm2.app and Terminal.app.

@bpinto
Copy link

bpinto commented Jul 22, 2016

I also have color issues on vim. They work correctly on Neovim however.

Colours are incorrect with and without set termguicolors.

@tnguyen14
Copy link

I have neovim but 256 colors are not working for me.. Am I doing something wrong?

@timothyis timothyis added the 🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper label Jul 26, 2016
@tnguyen14
Copy link

Is there any update on when this will be scheduled for?

@mak42
Copy link

mak42 commented Oct 26, 2016

Same problem here, in iTerm2 vim(nvim) colours look fine, but in hyperterm there wrong.

@nicholasc
Copy link

nicholasc commented Nov 15, 2016

Colors work when running tmux with set -g default-terminal "screen-256color" in the tmux.conf.

I created a work-around in my ~/.zshrc that fixes my vim colors. It creates a new tmux session named with the shell's PID and attaches a kill-session call when that shell is closed to cleanup after itself and not gather tons of tmux sessions.

alias tmuxn='tmux new-session -s $$'
_trap_exit() { tmux kill-session -t $$; }
trap _trap_exit EXIT
if ! [ -n "$TMUX" ]; then
    tmuxn
fi

It's quite dirty but it works for now. I wonder why running tmux fixes the colors. I also wonder if this issue is not linked to hterm itself.

@nicholasc
Copy link

nicholasc commented Dec 13, 2016

Adding set termguicolors in neovim config works here.

@patricklewis patricklewis mentioned this issue Jan 9, 2017
@rbeesley
Copy link

With Hyper, tput colors outputs 256 and $TERM is set to xterm-256color. However, any number of test scripts which use the \e[<38|48>;5;<0..255>mOUT\e[0m ANSI codes, shows that the terminal is only supporting 16 colors. Is $TERM set by the terminal, in this case Hyper? This is really playing havoc with my .dircolors and makes using Hyper practically unusable. I have already configured Bash in Bash on Ubuntu on Windows (WSL) and I want to be able to switch back and forth at will.

@chabou
Copy link
Collaborator

chabou commented Apr 18, 2017

I can't reproduce
capture d ecran 2017-04-19 a 00 18 16

Maybe only a WSL issue (see #1733)

@rbeesley
Copy link

@chabou Yes, that could be. I know the Console supports True Color now, but I suspect Hyper and bash.exe are going to have slightly different environments and terminal settings.

@s5bug
Copy link

s5bug commented May 28, 2017

Does not work with foreground or background

test

Windows, using bash.exe and angel-PS1

@infctr
Copy link

infctr commented Sep 3, 2017

is there any workaround for that?

how do you, guys, use zsh-autosuggestions? any setting for ZSH_AUTOSUGGEST_HIGHLIGHT_STYLE='fg=[0-7]' is either too bright, or just the same color as prompt text.

my setup: win10+cygwin+zsh

@Stanzilla
Copy link
Collaborator

xtermjs/xterm.js#484

@kinglouie
Copy link

On the latest 2.0 canary I have the same issue as in the first post from this thread. On 1.4.8, colortest from base16-shell works fine.

1.4.8

bildschirmfoto 2018-02-23 um 16 47 31

2.0 canary

bildschirmfoto 2018-02-23 um 16 49 53

@chabou
Copy link
Collaborator

chabou commented Feb 24, 2018

We're tracking this work over here: #2294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎨 Type: Enhancement Issue or PR is an enhancement request/proposal for Hyper
Projects
None yet
Development

No branches or pull requests