Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete/expansion broken on hyper 2.1.0-canary.2 #3278

Open
2 tasks done
andig opened this issue Nov 4, 2018 · 8 comments
Open
2 tasks done

Autocomplete/expansion broken on hyper 2.1.0-canary.2 #3278

andig opened this issue Nov 4, 2018 · 8 comments

Comments

@andig
Copy link

andig commented Nov 4, 2018

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: OSX Mojave

  • Hyper.app version: 2.1.0-canary.2

  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere):

    Plugin hyper-snazzy (1.3.0) loaded.
    Plugin hyper-statusline (1.7.6) loaded.
    Plugin hyper-alt-click (0.1.1) loaded.
    Plugin hyperterm-tab-icons (1.1.0) loaded.
    Plugin hyperlinks (0.5.0) loaded.
    Plugin hyperfullscreen (1.0.1) loaded.

  • The issue is reproducible in vanilla Hyper.app: Yes- removed all plugins and still present

Issue

Using TAB to complete adds invalid characters to the input. Consider this example where I hit TAB 3 times:

~
❯ cd htdocs/

~
❯ cd htdocs/
zsh: do you wish to see all 104 possibilities (26 lines)?

❯ cdcd htdocs/
Chart.js/                       fritzapi/                       modbus/                         syno-elk/

The 3rd time cd become cdcd. Here is another example how this looks (brbr):

screenshot 2018-11-04 at 17 29 28

@seanamosw
Copy link

This bug has now made it's way into 2.1.0 (stable).

Any tab completion results in the original input being "pinned" to the input line.
cd then TAB results in:
cdcd

The pinned characters seem to just be a visual artifact and do not affect actual input.
The characters cannot be removed via backspace/delete, you also cannot move the cursor to the characters with the arrow keys.

@andig
Copy link
Author

andig commented Dec 18, 2018

This bug has now made it's way into 2.1.0 (stable).

It has :( I can support testing if there's change but wouldn't know where to start with fixing.

@seanamosw
Copy link

Completely uninstalling (brew cask uninstall hyper) and reinstalling seems to have fixed it for me.

@alvinthen
Copy link

Reinstalling didn't fix the issue for me, although I'm retaining my .hyper.js, did you generate a new one?

@Sbax
Copy link

Sbax commented Dec 20, 2018

It's a locale issue, see #183

@andig
Copy link
Author

andig commented Dec 20, 2018

#183 was closed as fixed in 2016- seems its back if thats the root cause. I do have these locale settings for sake of reference:

LANG=en_DE.UTF-8
LC_CTYPE=en_DE.UTF-8

@Sbax
Copy link

Sbax commented Dec 20, 2018

Just tried with those locale settings and I'm also having issues, but I tried with LANG=de_DE.UTF-8 and my current locale LANG=it_IT.UTF-8 without having any problem.

@andig
Copy link
Author

andig commented Jan 2, 2019

Btw, still broken on canary 3.0 which has just landed today for me.

Fixed by workaround according to #3091 (comment), so #3369 might take care of the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants