Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper 2.0 shows wrong colors #2846

Closed
2 tasks done
rdev opened this issue Apr 17, 2018 · 7 comments
Closed
2 tasks done

Hyper 2.0 shows wrong colors #2846

rdev opened this issue Apr 17, 2018 · 7 comments
Labels
👀 Awaiting Response Issue or PR is awaiting a response from the author

Comments

@rdev
Copy link

rdev commented Apr 17, 2018

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name: macOS 10.13.3
  • Hyper.app version: Hyper 2.0.0 (stable)
  • Link of a Gist with the contents of your .hyper.js: My .hyper.js
  • Relevant information from devtools N/A
  • The issue is reproducible in vanilla Hyper.app: Yes

Issue

I'm using Hyper with Fish shell and this OMF theme
And since 2.0 update some colors are displayed incorrectly:

Here's iTerm (Hyper < 2.0 looked the same):
screen shot 2018-04-17 at 10 59 45 am

And on 2.0.0 the "❯" symbol is cyan:
screen shot 2018-04-17 at 10 59 49 am

It seems like #2bed9b color from the shell is swapped with lightCyan by Hyper

@albinekb
Copy link
Contributor

albinekb commented Apr 17, 2018

I can't see #2bed9b in your config 🤔

@rdev
Copy link
Author

rdev commented Apr 17, 2018

@albinekb it's not part of the config, it's in the Fish theme

Check here:
https://github.com/rdev/omf-theme-one/blob/f47998520622948c7a4259a761c6f7d27d603859/fish_prompt.fish#L1-L12

@connorwiebe
Copy link

yeah all the colors look faded/washed out for me too in 2.0

@albinekb
Copy link
Contributor

@rdev hmmm I wonder why that doesn't work. Thanks for pointing me there

All colors or just bold color? that could be #2836 @connorwiebe

@rdev
Copy link
Author

rdev commented Apr 18, 2018

@albinekb all colors

@chabou
Copy link
Collaborator

chabou commented Apr 19, 2018

@rdev It seems that you fish theme uses TrueColors and this is not compatible yet with our underlying terminal xtermjs

@connorwiebe default colors have changed to match iTerm2 theme (and permit use of brightColor). #2670 (comment)

@Stanzilla Stanzilla added the 👀 Awaiting Response Issue or PR is awaiting a response from the author label Apr 23, 2018
@arondeparon
Copy link

Similar issues here with ZSH and Agnoster theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👀 Awaiting Response Issue or PR is awaiting a response from the author
Projects
None yet
Development

No branches or pull requests

6 participants