Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shopify Navigation and menus #1272

Open
tanjunior opened this issue Jan 7, 2024 · 9 comments
Open

Shopify Navigation and menus #1272

tanjunior opened this issue Jan 7, 2024 · 9 comments

Comments

@tanjunior
Copy link

tanjunior commented Jan 7, 2024

I am following the Integration Guide it didn't exactly show an example for what value to enter for menu items. I tried a few ways and couldn't get it to work.

First I tried selecting Pages>About from the drop down menu.
image

When clicked on About in the footer it goes to domain/pages/about instead of domain/about

And if I set it as
image
It does not work when navigating from any search route. domain/search/shirts will go to domain/search/about

same as for header
image
Clicking on Stickers from Shirts domain/search/shirts will go to domain/search/search/stickers

@danieldanielecki
Copy link

I have the same problem, did you fix it?

@simpslandyy
Copy link

I'm also experiencing the same issue. :(

@danieldanielecki
Copy link

Oh, no sorry. I simply can't see navigation at all.
Have you faced such an issue?

@simpslandyy
Copy link

simpslandyy commented Jan 19, 2024

Similar, I'm noticing all the pages go to :domain/pages/:subpage> instead of :domain/:subpage and idky. :(

@issackj1
Copy link

issackj1 commented Jan 19, 2024

One possible solution for the issue of :domain/pages/:subpage is to follow the suggestion of OP and change the page links to /about instead of using the page "About".
Screenshot 2024-01-18 at 7 14 38 PM
If the site is hosted on vercel, it might be necessary to clear the cache on vercel to see the changes reflected on the navigation bar. I found that i had to do that before I could see the new navigation to :domain/:subpage instead of :domain/pages/:subpage.

I'm still have the last issue that OP mentioned.

same as for header image Clicking on Stickers from Shirts domain/search/shirts will go to domain/search/search/stickers

@issackj1
Copy link

And if I set it as image It does not work when navigating from any search route. domain/search/shirts will go to domain/search/about

same as for header image Clicking on Stickers from Shirts domain/search/shirts will go to domain/search/search/stickers

This change: issackj1@9a2ecec seems to fix it for me

@enterpriseSoftware
Copy link

Oh, no sorry. I simply can't see navigation at all. Have you faced such an issue?

Same!

@danieldanielecki
Copy link

Oh, no sorry. I simply can't see navigation at all. Have you faced such an issue?

Same!

Check #1281 (comment), it magically fixed by itself... super unstable repo tbh, didn't expect it from Vercel.

@backbone-link
Copy link

backbone-link commented Aug 9, 2024

There is also a caching issue. The current code force-cache's the results, so you won't get updates. I tried adding a new tag for updates under the Online Store section without luck. Shopify support also wasn't able to help (I tried Theme update and Shop update without luck). I resorted to adding a no-store cache for getMenu(). Happy to make a PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants