Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse cursor is not functioning properly in nested Vizy field. #267

Closed
dialedin-team opened this issue Nov 7, 2023 · 9 comments
Closed

Comments

@dialedin-team
Copy link

dialedin-team commented Nov 7, 2023

Describe the bug

Recenty i have upgraded craft cms version from 4.5.6.1 to 4.5.9, i noticed that mouse selection is not working properly when using fields inside a Vizy field and also when i double click outside of the field, the text cursor not showing in vizy field
Ref video: https://github.com/verbb/vizy/assets/148037067/86332d29-2491-419d-a8d9-251b2874aa83

Steps to reproduce

  1. The mouse cursor is not functioning properly when fields inside vizy field

Craft CMS version

4.5.9

Plugin version

2.1.11 and also 2.1.12

@dialedin-team dialedin-team changed the title The mouse cursor is not functioning properly in the nested Vizy field. The mouse cursor is not functioning properly when using fields inside a Vizy field Nov 7, 2023
@dialedin-team dialedin-team changed the title The mouse cursor is not functioning properly when using fields inside a Vizy field Mouse cursor is not functioning properly in fields that inside a Vizy field Nov 7, 2023
@dialedin-team dialedin-team changed the title Mouse cursor is not functioning properly in fields that inside a Vizy field Mouse cursor is not functioning properly in nested Vizy field. Nov 7, 2023
@engram-design
Copy link
Member

I believe this is a known issue with Tiptap and that fact that the Vizy block node has draggable: true, which makes double-clicking or highlighting text in some areas not work. This can be confirmed by changing

But that's not an option, as it would disable dragging Vizy blocks to re-order. Will raise with Tiptap. Related to ueberdosis/tiptap#1133

@thangaraj-moorthi
Copy link

Hi @engram-design
So, if I'm understanding correctly, we're facing either a dragging issue or a click issue. Is it not possible to address and resolve both of these problems? I appreciate your clarification.

@engram-design
Copy link
Member

It’s both, the cursor issue is due to the Tiptap component being draggable.

still looking into options to address it.

@dialedin-team
Copy link
Author

Hi @engram-design
I encountered the issue even after changing the draggable option from true to false. Therefore, I don't know the exact reason for it.

The problem with the mouse typing cursor in the inner field did not arise in Craft 4.5.6.1; it exclusively occurred in Craft version 4.5.9. Nevertheless, the mouse select issue happened in both versions.

@engram-design
Copy link
Member

Changing the draggable option from true to false won't do anything, unless you're re-building all the JS for the field. I'm also not suggesting to do this, as this would render Vizy blocks to be unable to be reordered.

Both mouse issues are related from my testing, and I'm seeing it in Craft 4.5.6.1 and earlier.

@engram-design
Copy link
Member

engram-design commented Nov 15, 2023

Okay, so after running 4.5.6.1 properly, I can see one issue is fixed and the other isn't, so looks like two separate issues! Looks like this was caused by the tabindex being removed on fields in craftcms/cms#13809

@engram-design
Copy link
Member

Fixed for the next release. To get this early, run composer require verbb/vizy:"dev-craft-4 as 2.1.12"

@dialedin-team
Copy link
Author

I appreciate your prompt resolution; thank you for the fix @engram-design

@engram-design
Copy link
Member

Fixed in 2.1.13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants