fix(core): Fix returning stale data in Role Update Event

[DanielBiegler]

Description

Previously it returned role which was fetched before(!) applying the update. See definition of role in line 253 and then the event bus publishing on line 281. I see that patchEntity is mutating the existing object instead of cloning which should be fine for the fields, but then the updatedAt is wrong since its not being updated by patchEntity. Event subscribers that depend on the updatedAt timestamp are receiving a wrong updatedAt and or other auto-updated columns.

Also removed the reference returned by pathEntity to make it visually clear that it actually mutates the object instead of returning a new one. This way its unambigious.

Note: Have not look at many other services where this might also be the case.

Question (Edit: solved and reverted)

Edit: Not going through findOne fails the role.e2e-spec.ts tests so I reverted it. Leaving it for history but the following can be ignored now.

---

I did remove the manual fetch since TypeORM reloads by default. I couldnt come up with an explanation why we are disabling reloading but then refetch manually anyway? I found the commit which disabled the reload 5 years ago but it doesnt make sense to me. The commit says:

By default, a TypeORM .save() operation will also immediately select the saved entity. In the case that the return value is not used, this is redundant and is switched off by passing the { reload: false } option.

Which makes sense, for cases where the return is not used, but in this case we really do want the new value and are refetching it manually via this.findOne(ctx, role.id) . Am I missing something? Maybe something with relations? findOne does add the channels relation in the query but is that relevant? 🤔

Breaking changes

No

Checklist

📌 Always:

• I have set a clear title
• My PR is small and contains a single feature
• I have checked my own PR

👍 Most of the time:

• I have added or updated test cases
• I have updated the README if needed

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	Oct 19, 2024 2:09pm

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[michaelbromley]

Looks good, thanks!