fix(core): Update DefaultMoneyStrategy.round() Logic #3023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Ah it looks like there are some tests & e2e tests that are dependent on the old rounding logic. They will need updating too. |
dfernandesbsolus
changed the title
michaelbromley
merged commit f43c204
into
vendure-ecommerce:minor
11 of 12 checks passed
|
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the DefaultMoneyStrategy.round() method to implement the updated rounding logic as discussed in #3003. The changes aim to improve the accuracy and consistency of the rounding behavior.
Breaking changes
NO
Screenshots
Before:
Now:
Checklist
📌 Always:
👍 Most of the time: