Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Make sku optional in create-product-variant-dialog #3007

Merged

Conversation

Dominic-Preap
Copy link
Contributor

Description

fix(admin-ui): make sku optional in create-product-variant-dialog

Breaking changes

N/A

Screenshots

N/A

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

vercel bot commented Aug 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Aug 10, 2024 0:48am

Copy link
Contributor

github-actions bot commented Aug 10, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Dominic-Preap Dominic-Preap changed the title fix(admin-ui): make sku optional in create-product-variant-dialog fix(admin-ui): Make sku optional in create-product-variant-dialog Aug 10, 2024
@Dominic-Preap
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Aug 10, 2024
@michaelbromley michaelbromley merged commit 13fe069 into vendure-ecommerce:master Aug 11, 2024
14 checks passed
@michaelbromley
Copy link
Member

Thank you!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants