feat(core): Create PromotionLineAction #2971
Merged
+222
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -149,6 +158,13 @@ export class Promotion | |||
| const promotionAction = this.allActions[action.code]; | |||
| if (promotionAction instanceof PromotionItemAction) { | |||
| if (this.isOrderItemArg(args)) { | |||
| const { orderLine } = args; | |||
| amount += | |||
| roundMoney(await promotionAction.execute(ctx, orderLine, action.args, state, this)) * | |||
There was a problem hiding this comment.
the roundMoney() function accepts a 2nd argument for quantity, so that the configured MoneyStrategy can control the multiplication.
There was a problem hiding this comment.
Thank you for the review.
It seems the issue arose because the previous quantity calculation logic was simply transferred.
I have added the calculation logic as an argument to roundMoney.
|
Thank you very much for your contribution and continued input in developing this feature! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To address the issue mentioned in the previous PR, I modified the return type of the
executemethod inPromotionItemActionto return either aNumberorExecutePromotionActionResult, allowing the inclusion ofdiscountMode.However, to maintain code consistency, I have added
PromotionLineActionand adjusted allPromotionActionsto return aNumbertype.Other tasks follow the contents of the attached previous PR.
Checklist
📌 Always:
👍 Most of the time: