fix(cookies): Correctly apply global and per-route middlewares #2911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a previous PR, I tried to fix an issue causing some per-route middlewares being broken when using the split cookies for the Admin and Shop APIs.
But since it was released in the
2.2.6
, the cookies split is no longer working at all.After investigating, it turned out we were still badly applying the per-route middleware:
bootstrap.ts
fileapp.modile.ts
file because of the configuration on the/
routeIn this PR, I made sure to:
shop
cookie namesession
cookieSession
middlewares on the/shop-api
and/admin-api
routesBreaking changes
No breaking change.
Screenshots
vendure.mp4
Checklist
📌 Always:
👍 Most of the time: