fix(cookies): Apply split cookie session middleware per route #2880
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using split cookies to have different cookie name for the
shop-api
and theadmin-api
, we used to apply thecookieSession()
middleware globally.However, Nest Global Middlewares can't be applied to specific routes.
By doing Global Middlewares, the last applied
app.use()
middleware was overriding the above-mentioned ones.Instead, we have to use Functional Middlewares for the specific paths we like.
As a consequence, for the case when the user wants to split the cookies, we do not do it in the
bootstrap()
function any longer but instead we do it in theAppModule.configure()
method, where other middlewares route-specific are already applied.Breaking changes
There is no breaking change as we just fix a behaviour that was not working.
Screenshots
N/A
Checklist
📌 Always:
👍 Most of the time: