Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrderByCodeAccessStrategy and DefaultOrderByCodeAccessStrategy are not exported #2664

Closed
floze opened this issue Feb 3, 2024 · 2 comments
Closed
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@floze
Copy link
Contributor

floze commented Feb 3, 2024

OrderByCodeAccessStrategy and DefaultOrderByCodeAccessStrategy are not exported from core, is this intentional? If I would want to simply configure anonymousAccessDuration I couldn't import the default strategy...

To Reproduce
Steps to reproduce the behavior:

  1. import { DefaultOrderByCodeAccessStrategy } from '@vendure/core';
  2. fail

Expected behavior
OrderByCodeAccessStrategy and DefaultOrderByCodeAccessStrategy should be available from the core.

Environment (please complete the following information):

  • @vendure/core version: v2.1.6
@floze floze added the type: bug 🐛 Something isn't working label Feb 3, 2024
@michaelbromley
Copy link
Member

Hi,

It's not intentional, just an oversight. Would you like to PR to master to fix this? You'd need to add the exports to this file.

In the mean time you can still import them via a deep import, i.e. @vendure/core/dist/config/order/order-by-code-access-strategy

@floze
Copy link
Contributor Author

floze commented Feb 21, 2024

Sure, I created a pull request #2692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants