Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update translations parent updatedAt column. #2630

Merged
merged 1 commit into from
Jan 22, 2024
Merged

fix: Update translations parent updatedAt column. #2630

merged 1 commit into from
Jan 22, 2024

Conversation

furo321
Copy link
Contributor

@furo321 furo321 commented Jan 19, 2024

Description

Previously when updating translations for a entity, it would only set the updatedAt for the translation itself. But now it will also update it for the parent (e.g. a product). Closes #1464

/claim #1464

Breaking changes

Screenshots

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

👍 Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

netlify bot commented Jan 19, 2024

Deploy Preview for effervescent-donut-4977b2 canceled.

Name Link
🔨 Latest commit e5e3b90
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/65aab86a3eb09900098ea361

Copy link

algora-pbc bot commented Jan 19, 2024

💵 To receive payouts, sign up on Algora, link your Github account and connect with Stripe/Alipay.

@michaelbromley michaelbromley merged commit 44fc828 into vendure-ecommerce:master Jan 22, 2024
16 of 18 checks passed
@michaelbromley
Copy link
Member

Nice and simple, thanks! 😄

@michaelbromley
Copy link
Member

/approve

Copy link

algora-pbc bot commented Jan 22, 2024

@michaelbromley: The claim has been successfully added to reward-all. You can visit your dashboard to complete the payment.

@michaelbromley
Copy link
Member

@furo321 please bear with me on the payment, I am waiting on a payment method to be set up on our end.

@michaelbromley
Copy link
Member

@furo321 can you please contact me at m.bromley [at] vendure.io?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The updatedAt timestamp does not change for translatable entities when their translations are updated
2 participants