Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

registerPageTab doesn't work for specific detail pages #2623

Closed
wayne12366 opened this issue Jan 15, 2024 · 1 comment
Closed

registerPageTab doesn't work for specific detail pages #2623

wayne12366 opened this issue Jan 15, 2024 · 1 comment
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@wayne12366
Copy link

Describe the bug
I've tried to add new tab under seller-detail page and I used the registerPageTab function with following locationId.
seller-detail
but it doesn't show any tabs under seller-detail page.
So i checked the source code, especially packages/admin-ui/src/lib/settings/src/settings.routes.ts.
and I found that some data is wrong in this file.
image

As you can see in screenshot, data.locationId ( seller-list ) is same for seller-detail and seller-list components.
then, i used that locationId to register new tab and now, the tab is shown under seller-detail page.
but i could also see the tab in seller-list page.
image
image

I can see such errors in stock-location, channel.

I'm sure this is minor issue and it will be fixed soon.

@wayne12366 wayne12366 added the type: bug 🐛 Something isn't working label Jan 15, 2024
@michaelbromley
Copy link
Member

Thanks for the report! This will be fixed in the next patch version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants