chore(admin-ui): Tab-bar color tweak

[chrislaai]

Description

Vendure blue is great so I did a little color tweak to keep us with this clean feel, without too much color.

Screenshots

Before:

After:

[netlify]

✅ Deploy Preview for effervescent-donut-4977b2 canceled.

Name	Link
🔨 Latest commit	4ebfc57
🔍 Latest deploy log	https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/65800019c5c4e6000888bfa4

[michaelbromley]

Hi Chris - thanks for the suggestion. I do think it looks good using the brighter blue but my main concern is the contrast ratio for accessibility.

With the current color of --color-primary-800, we have in the nav bar a contrast ratio of 6.2.
If we change it to --color-primary-600 then this drops to 2.31

To me that is more important than the aesthetics of it.

So I would say we should leave that active color as-is. However, I do think that the :hover style for the tab is a great addition - the current hover color is totally wrong.

Could you amend the commit to keep just the change to the tab hover style, and revert the --color-text-active change?

[chrislaai]

Hi Chris - thanks for the suggestion. I do think it looks good using the brighter blue but my main concern is the contrast ratio for accessibility.

With the current color of --color-primary-800, we have in the nav bar a contrast ratio of 6.2. If we change it to --color-primary-600 then this drops to 2.31

To me that is more important than the aesthetics of it.

So I would say we should leave that active color as-is. However, I do think that the :hover style for the tab is a great addition - the current hover color is totally wrong.

Could you amend the commit to keep just the change to the tab hover style, and revert the --color-text-active change?

Aha, my bad, I didn't notice that and I already revert.