Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix loading multiple customField relations #2566

Conversation

jnugh
Copy link
Contributor

@jnugh jnugh commented Dec 4, 2023

fixes #2555

Description

If a list query contained multiple customFields relations, only one had been assigned to the target entity. This fix allows storing multiple relations in customFields to be fetched.

Breaking changes

None

Checklist

📌 Always:

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

⚡ Most of the time:

  • I have added or updated test cases
  • I have updated the README if needed

Copy link

netlify bot commented Dec 4, 2023

Deploy Preview for effervescent-donut-4977b2 ready!

Name Link
🔨 Latest commit 55b5f35
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/656de03443ec2900085a179d
😎 Deploy Preview https://deploy-preview-2566--effervescent-donut-4977b2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@michaelbromley michaelbromley merged commit 99e04d1 into vendure-ecommerce:master Dec 11, 2023
18 checks passed
@michaelbromley
Copy link
Member

Thanks, this is an excellent contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ListQueryBuilder parallelLoadRelations does not handle multiple customFields correctly
2 participants