fix(core): send the correct amount to refundOrder
#2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for effervescent-donut-4977b2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
alexisvigoureux
changed the title
refundOrder on cancelled OrderLinesrefundOrder
|
Hi, thanks for the PR! It looks like this change is causing some e2e test failures though - can you look into that? |
|
It should be good |
michaelbromley
merged commit b5a265f
into
vendure-ecommerce:master
16 of 17 checks passed
|
Yeah the e2e tests flake out sometimes on port conflicts. Thanks for this impactful fix! |
alexisvigoureux
added a commit
to alexisvigoureux/vendure
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue #2523 related to #2302
Issue: The amount received by the
refundOrderfunction is 0After investigation,
orderPlacedQuantityis always 0 hereAs explained in the documentation, the order is persisted later, and overrides the value set in each orderLine update.
So, this PR defines the correct value for
orderPlacedQuantityof each orderLines when the order is placed to have the right value at persistence.Work done in pairs with @ttournie 🙏
Screenshots
Checklist
📌 Always:
⚡ Most of the time: