Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(admin-ui): Admin ui code templates #2545

Merged
merged 1 commit into from
Nov 24, 2023
Merged

fix(admin-ui): Admin ui code templates #2545

merged 1 commit into from
Nov 24, 2023

Conversation

tschortsch
Copy link
Contributor

Description

This PR fixes some syntax errors in the admin-ui code templates. (See #2544)

Checklist

  • I have set a clear title
  • My PR is small and contains a single feature
  • I have checked my own PR

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for effervescent-donut-4977b2 ready!

Name Link
🔨 Latest commit 79a92fd
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/65604fba30187000081368c5
😎 Deploy Preview https://deploy-preview-2545--effervescent-donut-4977b2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@michaelbromley michaelbromley merged commit a9e67fe into vendure-ecommerce:master Nov 24, 2023
3 checks passed
@michaelbromley
Copy link
Member

Thank you!

@tschortsch
Copy link
Contributor Author

I've just seen that there might we even more issues in the code templates. Probably by changes the interfaces of the addXY functions over time. Eg.

addNavMenuSection(
   {
      id: 'my-menu-item',
      label: 'My Menu Item',
      routerLink: ['/extensions/my-plugin'],
   },
   '${locationId}',
),

doesn't have a routerLink property directly but inside the items array. I'll try to fix those as well as soon as possible.

@tschortsch tschortsch deleted the fix/2544-code-templates branch November 24, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants