-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(email-plugin): Allow currencies with formatMoney helper #2531
feat(email-plugin): Allow currencies with formatMoney helper #2531
Conversation
MacOS CI failing doesn't look to be related to this PR |
Thanks, this is a long-overdue feature! Everything looks good - nice work on the docs and tests 👍 I think it would also make sense to update the default order confirmation template to use the correct currencyCode too. Would you like to include that in this PR too? |
Yep, missed that. Done! Edit: Any idea why that unit test is failing? |
The test output indicates that the
means "the first argument of the first call to |
Yep, my bad, I thought that issue was not due to my changes but it definitely was. The helper function threw an error and that was silently failing. All good now! |
E2E tests seem to throw |
Yes that's just an intermittent flakiness of the e2e tests when 2 test suites running in parallel try to listen on the same port. This all looks good now, thanks for your contribution! |
Description
Added 2 new parameters to the
formatMoney
helper: currency and localeCloses #2530
Breaking changes
Does this PR include any breaking changes we should be aware of?
No
Checklist
📌 Always:
⚡ Most of the time: