Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean custom Field sending empty string when false. #2362

Closed
axyut opened this issue Aug 25, 2023 · 0 comments
Closed

Boolean custom Field sending empty string when false. #2362

axyut opened this issue Aug 25, 2023 · 0 comments
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@axyut
Copy link

axyut commented Aug 25, 2023

Describe the bug
When trying to give false value for Boolean custom field it is sent as empty string.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new custom fields and set the type to Boolean. nullable being true was also tested.
    config

  2. Go to the customer tab (if custom fields pushed for customer) and uncheck to send the value as false.
    custom

  3. Try to update Customer

  4. See error
    error

Expected behavior
Just sending the false value instead of empty string "" and customer is updated.

Environment (please complete the following information):

  • "@vendure/core": "2.0.6",
  • "pg": "8.11.0",
  • "typescript": "4.9.5"
  • node : 18.16.0
@axyut axyut added the type: bug 🐛 Something isn't working label Aug 25, 2023
@michaelbromley michaelbromley moved this to 📋 Backlog in Vendure OS Roadmap Aug 29, 2023
@michaelbromley michaelbromley moved this from 📋 Backlog to 🏗 In progress in Vendure OS Roadmap Aug 30, 2023
@michaelbromley michaelbromley moved this from 🏗 In progress to 🔖 Ready in Vendure OS Roadmap Aug 30, 2023
@michaelbromley michaelbromley moved this from 🔖 Ready to ✅ Done in Vendure OS Roadmap Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
Status: 🚀 Shipped
Development

No branches or pull requests

2 participants