Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the table-layout to inherit always for better design when have… #2325

Closed
wants to merge 1 commit into from

Conversation

oidt
Copy link
Contributor

@oidt oidt commented Jul 28, 2023

… empty table (#2323)
In case of a empty table for orders, collections or other data tables the table will be inherit his columns and not overwrite each other.

https://user-images.githubusercontent.com/17176500/256823830-8643b143-32a2-4be6-a25e-17c7081eccc2.png

@netlify
Copy link

netlify bot commented Jul 28, 2023

Deploy Preview for effervescent-donut-4977b2 canceled.

Name Link
🔨 Latest commit b0b5a36
🔍 Latest deploy log https://app.netlify.com/sites/effervescent-donut-4977b2/deploys/64c3b907cb4b710008cc5e9e

@michaelbromley
Copy link
Member

Hi!

Thanks for the contribution. I agree with the change you are proposing, but I think that you can actually just delete the [style.table-layout]="!items?.length ? 'fixed' : 'inherit'" line entirely, since it should then revert to the default auto layout mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants