Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vendure 2.0.1: The surcharge price and priceWithTax getters are not rounded #2293

Closed
skid opened this issue Jul 17, 2023 · 1 comment · Fixed by #2294
Closed

Vendure 2.0.1: The surcharge price and priceWithTax getters are not rounded #2293

skid opened this issue Jul 17, 2023 · 1 comment · Fixed by #2294
Assignees
@michaelbromley
Labels
type: bug 🐛 Something isn't working

Comments

@skid
Copy link
Contributor

skid commented Jul 17, 2023

The surcharge entity can return a decimal number for the price and priceWithTax properties with the DefaultMoneyStrategy active. This happens because the roundMoney util is not used.

To Reproduce, just use a Surcharge and set tax rate that will guarantee a decimal number, then check those properties - one of them will most likely have decimals if your tax rate is not evenly

  • @vendure/core version: 2.0.1 through 2.0.4
@skid skid added the type: bug 🐛 Something isn't working label Jul 17, 2023
@skid
Copy link
Contributor Author

skid commented Jul 17, 2023

I'm opening a PR for this

@skid skid mentioned this issue Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelbromley michaelbromley

Labels
type: bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(core): Use MoneyStrategy in Surcharges paket-mk/vendure
2 participants
@skid @michaelbromley