feat(admin-ui): Add product variant bulk actions (assign/delete channel, delete) #2238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for effervescent-donut-4977b2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
…nnels This also refactors the fetching of variants in the dialog component.
DanielBiegler
commented
Jun 25, 2023
Comment on lines
+118
to
+130
| private async getTopVariants(take: number) { | ||
| return ( | ||
| await lastValueFrom( | ||
| this.dataService.product.getProductVariants({ | ||
| filterOperator: LogicalOperator.OR, | ||
| filter: { | ||
| productId: { in: this.productIds }, | ||
| id: { in: this.productVariantIds }, | ||
| }, | ||
| take, | ||
| }).single$, | ||
| ) | ||
| ).productVariants.items; |
There was a problem hiding this comment.
RxJs' toPromise is being deprecated, so I used the opportunity to simplify the fetching.
DanielBiegler
changed the title
|
Thanks so much for this! 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds assigning and deleting from channels and deletion of product variants as bulk-actions.