Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChannelService.findAll cache uses the API query limit #2233

Closed
goroka opened this issue Jun 15, 2023 · 1 comment
Closed

ChannelService.findAll cache uses the API query limit #2233

goroka opened this issue Jun 15, 2023 · 1 comment
Assignees
Labels
type: bug 🐛 Something isn't working

Comments

@goroka
Copy link
Contributor

goroka commented Jun 15, 2023

Describe the bug
Internal cache for channelservice (allChannels) refresh/findAll uses the default query limit of the API/Shop API instead of being unlimited. (default 1000)

To Reproduce
Create a multi channel site with over 1000+ channels.
On the admin page by selecting the channel that it is not in this 1k channel, the vendure triggers a CHANNEL-NOT-FOUND exception

Expected behavior
Should find it and the limit for the cached allChannels should be independent from the API query limite

Environment (please complete the following information):

  • @vendure/core version: 2.0.1
  • Nodejs version 18.16
  • Database (mysql/postgres etc): postgres
@goroka goroka added the type: bug 🐛 Something isn't working label Jun 15, 2023
@goroka
Copy link
Contributor Author

goroka commented Jun 15, 2023

temporary (not too nice :) workaround by increasing the adminListQueryLimit & shopListQueryLimit works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug 🐛 Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants