Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't throw exception when ad id is unavailable #33

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

dimamo5
Copy link
Collaborator

@dimamo5 dimamo5 commented Sep 11, 2020

No description provided.

@dimamo5 dimamo5 requested a review from duartepinto September 11, 2020 11:00
@dimamo5 dimamo5 self-assigned this Sep 11, 2020
@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #33 into master will decrease coverage by 0.64%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #33      +/-   ##
============================================
- Coverage     67.94%   67.30%   -0.65%     
  Complexity        1        1              
============================================
  Files             8        8              
  Lines           156      156              
  Branches         21       20       -1     
============================================
- Hits            106      105       -1     
- Misses           41       43       +2     
+ Partials          9        8       -1     
Impacted Files Coverage Δ Complexity Δ
...c/main/kotlin/com/velocidi/GetAdvertisingIdTask.kt 5.55% <0.00%> (-0.70%) 0.00 <0.00> (ø)
velocidi-sdk/src/main/kotlin/com/velocidi/Util.kt 70.00% <0.00%> (+1.25%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a21b3ce...4c1c77c. Read the comment docs.

Copy link
Contributor

@duartepinto duartepinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the urgency of this PR I think that it is ok, but can you open an issue stating that we should change how we return an invalid AdvertisingInfo? Maybe return as a nullable 🤷

@dimamo5
Copy link
Collaborator Author

dimamo5 commented Sep 11, 2020

Given the urgency of this PR I think that it is ok, but can you open an issue stating that we should change how we return an invalid AdvertisingInfo? Maybe return as a nullable 🤷

Agree. I'll do that later.

@duartepinto duartepinto merged commit 77765e5 into master Sep 11, 2020
@duartepinto duartepinto deleted the avoid-exception branch September 11, 2020 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants