Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YAML safe_load call arguments #26

Merged
merged 4 commits into from
Mar 24, 2022
Merged

Fix YAML safe_load call arguments #26

merged 4 commits into from
Mar 24, 2022

Conversation

queimadus
Copy link
Contributor

@queimadus queimadus commented Mar 24, 2022

This was failing in ruby 3.1 because of ruby/psych#533.

The changes are similar to the fix here: iknow/loadable_config#12.
These changes should be retro-compatible with the previous versions of ruby we're still supporting.

@queimadus queimadus requested a review from dimamo5 March 24, 2022 10:16
@queimadus queimadus self-assigned this Mar 24, 2022
@coveralls
Copy link

coveralls commented Mar 24, 2022

Pull Request Test Coverage Report for Build 2033895772

  • 12 of 12 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.0%) to 99.842%

Totals Coverage Status
Change from base Build 617462134: 0.0%
Covered Lines: 633
Relevant Lines: 634

💛 - Coveralls

This is why 3.1 is getting installed. Specifying `3` directly to
avoid confusion.
Copy link
Contributor

@dimamo5 dimamo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@dimamo5 dimamo5 merged commit 72f4d5b into master Mar 24, 2022
@dimamo5 dimamo5 deleted the fix-yaml-safe-load branch March 24, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants