Git master not loading old saved games correctly.

[evertvorster]

Git master version as of 2025-02-05 is not loading older saved games correctly.

Ships don't have any of the upgrades that were purchased.

When purchasing new upgrades and saving it, the HUD does not show the new upgrades.
The graphic for the ship in the hangar disappears when upgrades are bought.

I'll have to bisect and see which commit caused this, and whether it is in Assets or Engine.
Any clues to which commit may have caused this would be welcome.

I tested with a stock Vendetta and a milspec Goddard.

[kheckwrecker]

It's definitely not the latest commit (#1017) as I haven't applied that one yet, and I'm having the problem with the graphic for the ship in the hanger disappearing. However, I'm not seeing the issue of ships losing upgrades. All of mine are still there when I load saved games.

Also, I previously reported the missing ship graphics in issue #1019. It happens to me whether I buy any upgrades or not. Finally, I didn't include it in my previous report, but for me, the ships graphic doesn't show in the HUD at all. All that shows are the shields around an empty space.

[royfalk]

Don't bother doing some exhaustive tests of this just yet.
Please upload our saved games here. I'll take a look.
I'll see if I can tell what's happening quickly.

Just to be clear, old save games with units saved as CSV files are no longer supported. They need to be converted using a python script. See #922.

[evertvorster]

OK, that can also work. Do you just need the saves, or the serialized xml as well?

The two saved games with the purchased items missing:

0.9.x_Advanced_Trade_Vendetta.zip

Goddard_kissing_ass.zip

I took one of those, and bought new items. Then, when I go to the landing pad, the graphic of the ship is missing, and also in the HUD the items that I bought is not displayed. Here is the saved game for that:

Git_Master_Adv_trade_Vendetta.zip

[royfalk]

I just need the serialized xml, which is actually either CSV or json.

If it's CSV, don't bother. That's the reason for the lack of upgrades. The ship is loaded from units.json instead, as <ship_name>.json is missing.

As for the missing hud picture, that's a different issue that needs investigating.

[evertvorster]

So, how do I convert from csv to json? Surely when the assets were converted to json a script was used... can I have a copy?

I would like to have these older saved games work, as they represent a significant amount of play time.

The HUD picture is there, but it is missing the elements of upgraded components, like capacitors

[royfalk]

I had a nice utility which I myself used. I thought I uploaded it as part of the asset production PR but I'm not finding it I'll try again tonight.
Worst case I'll rewrite it again.

[evertvorster]

It would be super handy to have, and yes, it should be part of Assets.

[kheckwrecker]

Here's the json file for my saved game (serialized XML) that shows the ship graphic not showing on the landing pad. I'm not sure about the issue of missing upgrades. Mine seem to be there. I just went back and purchased a bunch of upgrades, saved the game, and on reload they all show up in my HUD.

This save game also shows another interesting bug that someone else previously reported. When you first load the game, it sometimes starts with my ship in space. You can however just land on Atlantis right away. Then you'll be able to observe that the graphic for the ship does not display. Weirdly enough, it also sometimes starts in the hangar.

Dostoevsky.stock.json

(edited to attach updated file)

[royfalk]

It would be super handy to have, and yes, it should be part of Assets.

vegastrike/Assets-Production#157

I apologize. I actually worked on it when I worked on the PR deprecating CSV but somehow it got left in a stash. This is also why it took me a while to find the darned thing.

[evertvorster]

This is now fixed.

To be clear, the file added by vegastrike/Assets-Production#157 needs to be placed into ~.vegastrike/serialized_xml folder, and then run.
This will translate your .csv files of your ships to .json files which can be read by the new version of the engine.