Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine local timezone on client instead of server #79

Closed
jonmmease opened this issue Feb 26, 2022 · 0 comments · Fixed by #82
Closed

Determine local timezone on client instead of server #79

jonmmease opened this issue Feb 26, 2022 · 0 comments · Fixed by #82
Labels
enhancement New feature or request

Comments

@jonmmease
Copy link
Collaborator

Currently, calculations that involve converting the stored UTC time to Local time are performed according to the server's timezone. Instead, this timezone should be determined by the client.

As a new architecture, the client should provide its named timezone as part of the task graph query. Then we can use chrono-tz on the server to convert from UTC to the local time zone. For hashing, it might be easier to add the timezone to each transform/expression that needs it, and then include the timezone string in the hash of expression/transform.

@jonmmease jonmmease added the enhancement New feature or request label Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant